CI tests #53
Open
CI tests #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blerer
approved these changes
May 30, 2023
|
This is ready to commit, but we must upload the test image in a different location compliant with Apache. Low-priority task, until then, we cherry-pick the commit to trigger testing in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some initial CircleCI config. Test run can be seen here - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/jamm/37/workflows/43ea4ab3-3101-4a2a-99ec-b4f4719c25ff
It runs the tests as per the run-tests.sh with JDK8, 11 and 17; 32 bits and 64 bits
Currently we do not store artifacts. The current tests do not output some lengthy meaningful logs.
We see enough under RUN TESTS step of the respective job we want to check (Steps tab)
ContendedPaddingWidthandEnableContendedarguments don't also work as expected with latest JDK11 installed in the CI image. I noticed Jol is handling @contended so maybe we can check on what they do too.Currently the test image is published in my own Docker Hub repo, TBD
I also added a fix for GuessTest as in Linux even if I run tests with JDK8, javac was trying to compile with JDK17 no matter where my JAVA_HOME points to. Setting source and target explicitly helped.