Skip to content

Commit

Permalink
DepCard: Push the border rect beneath the icon/text
Browse files Browse the repository at this point in the history
I'd shifted this in 25fadc4 (DepCard: Add tasks, tasksCompleted, and
a progress bar, 2016-11-28, #18) with some rough thoughts about
clipping long slugs so they don't overflow the card.  But it meant
that the border rect masked the links provided by the icon and text.
This commit shifts the border rect lower in the stack so you can get a
click through to the active elements again.  We'll need a more robust
solution to clipping/overflow anyway.
  • Loading branch information
wking committed Nov 28, 2016
1 parent 5226d3c commit b59928e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions webapp/src/DepCard.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ class DepCard extends PureComponent {
rx={radius} ry={radius} style={backgroundStyle}>
</rect>
<path d={taskPath.join(' ')} style={taskStyle} />
<rect
x={left} y={top} width={width} height={height}
rx={radius} ry={radius} style={style}>
</rect>
<a xlinkHref={host}>
<image
x={leftCenter} y={this.props.cy - 0.4 * height}
Expand All @@ -138,10 +142,6 @@ class DepCard extends PureComponent {
{this.props.slug.replace(/^[^\/]*\//, '')}
</text>
</a>
<rect
x={left} y={top} width={width} height={height}
rx={radius} ry={radius} style={style}>
</rect>
<DepIndicators
cx={right} cy={this.props.cy} dy={height/2}
blockers={this.props.blockers}
Expand Down

0 comments on commit b59928e

Please sign in to comment.