DepCard: Push the border rect beneath the icon/text #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd shifted this in 25fadc4 (DepCard: Add tasks, tasksCompleted, and a progress bar, 2016-11-28, jbenet#18) with some rough thoughts about clipping long slugs so they don't overflow the card. But it meant that the border rect masked the links provided by the icon and text. This commit shifts the border rect lower in the stack so you can get a click through to the active elements again. We'll need a more robust solution to clipping/overflow anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd shifted this in #18 with some rough thoughts about clipping long slugs so they don't overflow the card. But it meant that the border rect masked the links provided by the icon and text. This commit shifts the border rect lower in the stack so you can get a click through to the active elements again. We'll need a more robust solution to clipping/overflow anyway.