Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Race #2

Open
btc opened this issue Dec 18, 2014 · 4 comments
Open

Data Race #2

btc opened this issue Dec 18, 2014 · 4 comments

Comments

@btc
Copy link
Contributor

btc commented Dec 18, 2014

https://build.protocol-dev.com/job/race/9225/console

WARNING: DATA RACE
Read by goroutine 6:
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream.(*Swarm).Conns()
      /workspace/race/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream/swarm.go:113 +0x81
  github.com/jbenet/go-ipfs/net/swarm.(*Swarm).ConnectionsToPeer()
      /workspace/race/src/github.com/jbenet/go-ipfs/net/swarm/swarm.go:119 +0x116
  github.com/jbenet/go-ipfs/net/swarm.(*Swarm).NewStreamWithPeer()
      /workspace/race/src/github.com/jbenet/go-ipfs/net/swarm/swarm.go:91 +0x125
  github.com/jbenet/go-ipfs/net.(*network).NewStream()
      /workspace/race/src/github.com/jbenet/go-ipfs/net/net.go:201 +0x9a
  github.com/jbenet/go-ipfs/net/backpressure.TestStBackpressureStreamWrite()
      /workspace/race/src/github.com/jbenet/go-ipfs/net/backpressure/backpressure_test.go:308 +0x886
  testing.tRunner()
      /usr/local/go/src/pkg/testing/testing.go:422 +0x10f

Previous write by goroutine 12:
  runtime.mapassign1()
      /usr/local/go/src/pkg/runtime/hashmap.goc:925 +0x0
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream.func��002()
      /workspace/race/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream/conn.go:176 +0x55a
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream.(*Swarm).addConn()
      /workspace/race/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream/conn.go:180 +0x236
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream.(*Listener).accept()
      /workspace/race/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-peerstream/listener.go:98 +0x202
jbenet added a commit that referenced this issue Dec 18, 2014
jbenet added a commit that referenced this issue Dec 18, 2014
maybe this fixes that odd one.
@jbenet
Copy link
Owner

jbenet commented Dec 18, 2014

Thanks!

@jbenet
Copy link
Owner

jbenet commented Dec 18, 2014

@maybebtc is this going to run automatically again, or do i need to trigger it somewhere?

@btc
Copy link
Contributor Author

btc commented Dec 18, 2014

race detection is run on IPFS master every 5 minutes around the clock

@btc
Copy link
Contributor Author

btc commented Dec 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants