moving to jakarta packages #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: pom.xml
|
I think it's easier to have jberet-parent as the parent pom. jberet-pom in turns inherits from jboss-parent . It helps reduce quite a lot duplicate elements, maintain consistent dependency versions, and a common releasing mechanism and standard. |
|
@chengfang I restored the parent pom Is this ok now ? |
chengfang
reviewed
Jul 28, 2022
|
@chengfang removed unnecessary overrides |
chengfang
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chengfang
I moved the library to jakarta packages.
I also removed the reference to the parent pom, since the library is going to have a different versioning and it has a minimal subset of dependencies and most of them have different versions.
Is this ok to you ?