Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody.
I implemented the JPA Job Repository, I tested and I am using this with Wildfly.
I noticed there was already an empty maven project for this, so I filled that.
Please notice this implementation does not cache entities, since JPA implementations already do that for us (again, we don't want to reinvent the wheel).
I also preferred Annotation approach over the orm.xml one, for the latter's syntax is not powerfull enough (lot of missing options and JPA functionalities).
This also fixes (when using JPA, and it is possible to migrate from jdbc to jpa out of the box):
#142
I will also make a pull request for the wildfly jberet integration as soon as this pull request is accepted and the library published.
@chengfang can you please accept the pull or let me know if you need something more/else ?
Also, what about 1.4.x and master branch ? Are you going to merge this into those branches too or do you'd rather have me to do so?
Waiting for your feedback.