Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JpaJobRepository #176

Closed
wants to merge 8 commits into from
Closed

JpaJobRepository #176

wants to merge 8 commits into from

Conversation

amoscatelli
Copy link

@amoscatelli amoscatelli commented Dec 17, 2021

Hi everybody.
I implemented the JPA Job Repository, I tested and I am using this with Wildfly.
I noticed there was already an empty maven project for this, so I filled that.

Please notice this implementation does not cache entities, since JPA implementations already do that for us (again, we don't want to reinvent the wheel).
I also preferred Annotation approach over the orm.xml one, for the latter's syntax is not powerfull enough (lot of missing options and JPA functionalities).

This also fixes (when using JPA, and it is possible to migrate from jdbc to jpa out of the box):
#142

I will also make a pull request for the wildfly jberet integration as soon as this pull request is accepted and the library published.

@chengfang can you please accept the pull or let me know if you need something more/else ?
Also, what about 1.4.x and master branch ? Are you going to merge this into those branches too or do you'd rather have me to do so?

Waiting for your feedback.

@amoscatelli
Copy link
Author

Windows test fails with:

Caused by: java.lang.UnsatisfiedLinkError: C:\buildAgent\temp\buildTmp\librocksdbjni4142663388798358572.dll: Can't find dependent libraries

I can't see how can this be related to my changes ....
Can anyone help ?

@amoscatelli amoscatelli changed the title 1.3.x JpaJobRepository Dec 17, 2021
@chengfang
Copy link
Contributor

Thanks for the contribution!

1.3.x is for maintenance and closed for feature development. Can you move this PR to https://github.com/jberet/jberet-jpa-repository? and we can continue discussion there.

We can integrate jpa repository into jberet-se. To integrate jpa repository with WildFly, it will need more thinking and non-trivial work in WildFly batch subsystem, and currently the benefits don't seem to warrant that.

@amoscatelli
Copy link
Author

Thanks for the contribution!

1.3.x is for maintenance and closed for feature development. Can you move this PR to https://github.com/jberet/jberet-jpa-repository? and we can continue discussion there.

We can integrate jpa repository into jberet-se. To integrate jpa repository with WildFly, it will need more thinking and non-trivial work in WildFly batch subsystem, and currently the benefits don't seem to warrant that.

I am going to make a pull request for master then ...

Please notice that I needed some minor changes to jberet-core too.
Are you sure I have to move the pull request there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants