Add support for ECC signatures by switching to Crypt::PK::* #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no Crypt::OpenSSL::* module to support ECC signatures, which the JWT standard specifies. As a result, this module currently does not support ECC tokens, only HMAC and RSA ones. Switch to Crypt::PK::* instead, which does have a ECC module that has the exact same API as its RSA counterpart. As an added advantage, Crypt::PK::RSA also supports importing/exporting RSA keys in JWK format, which Crypt::OpenSSL::RSA does not. This might be useful for a module dealing with JSON Web Tokens. Signed-Off-By: Wouter Verhelst <w@uter.be>
|
[update: fix test suite, which uncovered code issues -- it does work now, sorry] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no Crypt::OpenSSL::* module to support ECC signatures, which
the JWT standard specifies. As a result, this module currently does not
support ECC tokens, only HMAC and RSA ones.
Switch to Crypt::PK::* instead, which does have a ECC module that has
the exact same API as its RSA counterpart.
As an added advantage, Crypt::PK::RSA also supports importing/exporting
RSA keys in JWK format, which Crypt::OpenSSL::RSA does not. This might
be useful for a module dealing with JSON Web Tokens.
Signed-Off-By: Wouter Verhelst w@uter.be