Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change representation_series to DataFrame #156

Merged
merged 24 commits into from
Sep 12, 2020
Merged

Change representation_series to DataFrame #156

merged 24 commits into from
Sep 12, 2020

Commits on Aug 18, 2020

  1. added MultiIndex DF support 

    suport MultiIndex as function parameter

returns MultiIndex, where Representation was returned

* missing: correct test


Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @mk2510 @henrifroese
    mk2510 and henrifroese committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    fa342a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. beginning with tests

    @henrifroese
    henrifroese committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    59a9f8c View commit details
    Browse the repository at this point in the history

  2. implemented correct sparse support 

    *missing: test adopting for new types


Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @mk2510 @henrifroese
    mk2510 and henrifroese committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    19c52de View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Merge branch 'master_upstream' into change_representation_to_multicolumn

    @mk2510
    mk2510 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    66e566c View commit details
    Browse the repository at this point in the history

  2. added back list() and rm .tolist()

    @mk2510
    mk2510 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    41f55a8 View commit details
    Browse the repository at this point in the history

  3. rm .tolist() and added list()

    @mk2510
    mk2510 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    217611a View commit details
    Browse the repository at this point in the history

  4. Adopted the test to the new dataframes

    @mk2510
    mk2510 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    6a3b56d View commit details
    Browse the repository at this point in the history

  5. wrong format

    @mk2510
    mk2510 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b8ff561 View commit details
    Browse the repository at this point in the history

  6. Address most review comments.

    @henrifroese
    henrifroese committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e3af2f9 View commit details
    Browse the repository at this point in the history

  7. Add more unittests for representation

    @henrifroese
    henrifroese committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    77ad80e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. implemented the suggested changes

    @mk2510
    mk2510 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    e2768b5 View commit details
    Browse the repository at this point in the history

  2. fixed messy docstring

    @mk2510
    mk2510 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    b09f624 View commit details
    Browse the repository at this point in the history

  3. fix black issues

    @mk2510
    mk2510 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    508c361 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @mk2510
    mk2510 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    75e955f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. changed s to input_matrix

    @mk2510
    mk2510 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    7fec40e View commit details
    Browse the repository at this point in the history

  2. resolving smaller comment issues

    @mk2510
    mk2510 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    4b5c67b View commit details
    Browse the repository at this point in the history

  3. updated name of the function

    @mk2510
    mk2510 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    00ff777 View commit details
    Browse the repository at this point in the history

  4. added some docstring improvements

    @mk2510
    mk2510 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    e8d1816 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. edited docstrings and DocumentTermDF

    @mk2510
    mk2510 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3ba2ebc View commit details
    Browse the repository at this point in the history

  2. uniform docstring

    @mk2510
    mk2510 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    111ced6 View commit details
    Browse the repository at this point in the history

  3. formatting done

    @mk2510
    mk2510 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b3823e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Fix small stuff from review.

    @henrifroese
    henrifroese committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    efcf8c0 View commit details
    Browse the repository at this point in the history

  2. incorporate suggested changes

    @henrifroese
    henrifroese committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    6e0c831 View commit details
    Browse the repository at this point in the history

  3. re-skip doctest as it fails on macOS

    @henrifroese
    henrifroese committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    3f8b734 View commit details
    Browse the repository at this point in the history