-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for Series Types (Representation Series, Tokenized Series, ...). #69
Checking for Series Types (Representation Series, Tokenized Series, ...). #69
Conversation
File _helper.py implements Series types for the library. Would implement jbesomi#60 .
Henri you are awesome!! 🎉🎉 |
Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>
We have now worked on this again; should be ready for a review/discussion (and maybe a merge) @jbesomi . Summary (everything is explained more extensively in docstrings in
Use Cases: We can now do two things:
This is very expressive for the users in the documentation (and also for the developers)! Everyone can immediately see what tfidf is working on and what the output looks like. Doing This does not force users to do anything differently from before, they should just continue using Pandas Series as usual; it's mainly for documentation / ease of use / expressiveness. This also automatically adds good explainations through the docstrings. Second of all, the decorator (probably self-explanatory):
All of this is implemented very lightweight and adds basically no overhead; the type checking etc. is all O(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! 🎉 That's soo nice and soo cool (and soo simple too) !!
- rename "DocumentRepresentationSeries" to "RepresentationSeries"
Just renamed "DocumentRepresentationSeries" to "RepresentationSeries" |
Everything looks great! I will merge it now ... the only observation: what if we move this under a separate file? Like |
This is mainly meant as a first step towards closing #60 and should not be merged yet. It implements three types of custom pandas Series that implement the most common usages in the library. Also adds decorators for easier development using the types. See the discussion in #60 for more information.