Implement Automated Readability Index, Closes #20 ; new PR; Waiting until Checking for NaNs is implemented. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New pull request from jbesomi#46 as we had some Git problems. Input checking done with pd.api.types.is_string_dtype. Not a permanent solution, will be improved by jbesomi#60 etc. Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>
|
This looks very good! The only question: "Score is NaN if it cannot be computed (e.g. if the number of sentences is 0).", are we testing this scenario there? |
Better check for NaNs and non-string values at the beginning. Additional test in test_visualization for NaNs.
|
You're right, I totally missed that. I just improved the testing at the beginning of the function in a new commit. I also added a test for that in test_visualization. |
|
Yes, makes sense |
henrifroese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request from #46 as we had some Git problems.
Input checking done with pd.api.types.is_string_dtype. Not a
permanent solution, will be improved by #60 etc.