Port Mono.Cecil to .NET Standard 2.0. #542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the target runtime to .NET Standard 2.0. Removed some conditional compilation ifs that were removing the ability to strong name code. Bring back code in BaseAssemblyResolver that builds on .NET Standard 2.0, enabling the search of assemblies in the GAC, allowing the code to find assemblies in the GAC, even when referenced from a net461 DLL in .NET Framework full.
|
After creating this PR, I noticed that this PR #527 seems to do the same, but a lot more (changing the whole SDK and files, a more complete solution). Feel free to close this PR if the other solution is better or more suitable for the Project. |
|
Thank you for your contribution! We landed a different set of changes to move to the new SDK and to .NET Standard 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the target runtime to .NET Standard 2.0.
Removed some conditional compilation ifs that were
removing the ability to strong name code.
Bring back code in BaseAssemblyResolver that builds on
.NET Standard 2.0, enabling the search of assemblies in the
GAC, allowing the code to find assemblies in the GAC, even when
referenced from a net461 DLL in .NET Framework full.
I am not sure if the .NET Standard 2.0 DLL assemblies referenced in the nuspec file needs to be updated or not.
I ran the tests in .NET Standard 2.0 and all worked.
This PR is motivated by dsplaisted/strongnamer#31, in an effort to make it available on Linux. Sadly, this is not fully possible as of https://github.com/dotnet/corefx/issues/11225.