Reduce some GC pressure that adds up in several unity workloads. #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbevain
reviewed
Dec 6, 2019
jbevain
changed the title
|
We just need to address the tidbit and that's good to go. Thanks for the contribution! |
jbevain
reviewed
Dec 7, 2019
|
Thanks again! |
|
@lucasmeijer do you have any indicative numbers on the perf improvements this results in? |
|
@SimonCropp no, the workload I was testing on has high varience, but on many dottrace traces Collection.Grow did show up, and the two causes were the sequencepoints and the generic instantiation arguments. This is definitely in the small fish category. |
|
@lucasmeijer thanks for the clarification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.