Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locally scoped constant array #644

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Fix locally scoped constant array #644

merged 5 commits into from
Jan 31, 2020

Conversation

SimonCropp
Copy link
Contributor

@jbevain seems to me an array should be treated the same as a object type for this context?

@SimonCropp
Copy link
Contributor Author

put in a diff PR since i am confident the fail test verifies the scenario. but am uncertain about this as a fix

@jbevain
Copy link
Owner

jbevain commented Jan 30, 2020

Thanks for the PR. The fix is good!

@jbevain jbevain changed the title Possible fix for locally scoped constant array Fix locally scoped constant array Jan 31, 2020
@jbevain jbevain merged commit 933575c into jbevain:master Jan 31, 2020
@jbevain
Copy link
Owner

jbevain commented Jan 31, 2020

Thanks for the PR!

@marek-safar marek-safar mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbevain jbevain jbevain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @jbevain