Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move packages into monorepo #40

Merged
merged 354 commits into from
Aug 15, 2024
Merged

Conversation

lalalune
Copy link
Collaborator

@lalalune lalalune commented Aug 15, 2024

This is a massive PR. All other packages imported and all files are moved. It is 350+ commits because it merges the history from the other packages.

This PR moves all of the other clapper/aitube packages together into a monorepo.

It preserves history of each of the different projects, using some git history rewrite to place them correctly in the monorepo.

Bun manages the monorepo, so there are no new tools. npm run dev still works, but is now powered by bun.

There are a few issues -- a couple of the Clapper imports are circular and have been commented out and replaced by any -- for example import { ClapSegmentCategory } from "@aitube/clap" in broadway/types

@xenova/transformers will not import from git with bun, so this has been commented out as well

@lalalune lalalune changed the title Mov packages into monorepo Move packages into monorepo Aug 15, 2024
@devniel
Copy link
Collaborator

devniel commented Aug 15, 2024

Hi,

Thanks, really cool, this will help a lot, specially for contributing to the Timeline component; just two things I found while testing it.

  • I think we will need to update the README.md to add installing bun as requirement.

  • When trying npm run dev, I'm getting this issue; *I tried removing the bun.lockb and node_modules and still the same, using Bundler as tsconfig moduleResolution doesn't fix it :

Import trace for requested module:
./src/app/page.tsx
 ⨯ ./src/app/main.tsx:8:1
Module not found: Can't resolve '@aitube/clapper-services'
   6 | import { DndProvider, useDrop } from 'react-dnd'
   7 | import { HTML5Backend, NativeTypes } from 'react-dnd-html5-backend'
>  8 | import { UIWindowLayout } from '@aitube/clapper-services'
     | ^
   9 | import { ErrorBoundary, FallbackProps } from 'react-error-boundary'
  10 |
  11 | import { Toaster } from '@/components/ui/sonner'

Copy link
Owner

@jbilcke-hf jbilcke-hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

I'm trusting you on this one!

Let's merge the PRzilla 🦖

(if there are issues we can merge them later)

@jbilcke-hf jbilcke-hf merged commit ebea0c0 into jbilcke-hf:main Aug 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants