Fixing my JK BMS RS485 issue. #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the contribution - not sure if this is needed (as dalyserial would solve the issue) or generic enough but i dont see it hurting (and mppsolar is a bit of a mess of bits anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the issue described by my comment here #506 (comment) also a continuation of this issue #112
It appears to be working fine for me.
The change adds a new serialio called jkserialio. The only difference from serialio is that instead of waiting for a CR it now waits for a specific byte sequence 68 00 00 XX XX (last 2 bytes are the CRC so can be anything). A better approach would be to process frame header and extract length info, but this was quicker to implement.