Create UMD-style wrapper for PathUtils and add a package.json #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jblas,
there was some discussion about
PathUtils
in the Adobe/Brackets-project repo some time ago:adobe/brackets#11726
PathUtils
was eventually reverted as it was in Brackets, but as I was working on another feature this weekend I noticed that module wrappingPathUtils
would still be useful for Brackets in the long run.This PR does the following (small changes):
require("./path-utils")
require(["path-utils"], function (PathUtils) { /***/ });
<script src="path-utils.js"></script>
)npm
)npm init
so that the module can be installed from GitHub withnpm
. If you wish to publish the module intonpm
ecosystem at some point, you can follow the instructions at [NPM docs - Publishingnpm
packages](https://docs.npmjs.com/getting-started/publishing-npm-packages].jblas-path-utils
aspath-utils
is already taken. Unless you release the module tonpm
, this doesn't matter much.path-utils.js
was uglified withUglifyJS
JSDoc
@license field so that UglifyJS doesn't eat it.If there's anything that you would like to change, something is wrong in the commit in general or you have some questions, I'll gladly follow up on it. If you want to land this on another branch or not at all, that's okay too 👍