Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXCop warning CA1034 #33

Open
gbelzile opened this issue Jan 7, 2019 · 3 comments
Open

FXCop warning CA1034 #33

gbelzile opened this issue Jan 7, 2019 · 3 comments

Comments

@gbelzile
Copy link

gbelzile commented Jan 7, 2019

FXCop is not happy with nested public classes. How would you refactor?

@jbogard
Copy link
Owner

jbogard commented Jan 7, 2019 via email

@gbelzile
Copy link
Author

gbelzile commented Jan 7, 2019

Sorry but this is always the wrong/lazy answer. I'll change handlers to internal and create separate classes for requests since they are exposed in the controller. Thanks anyway. I still love most part of this project.

@jbogard
Copy link
Owner

jbogard commented Jan 7, 2019

Ha! Well it's what I would do. It's a bad rule.

Alternative is to use prefixes on class. So instead of Foo.Handler, FooHandler. Or you can use namespaces instead of inner classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants