Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v11 Breaking Change #792

Closed
jeparrish opened this issue Oct 20, 2022 · 1 comment
Closed

v11 Breaking Change #792

jeparrish opened this issue Oct 20, 2022 · 1 comment

Comments

@jeparrish
Copy link

On the What's New for v11, the change "CA1068: CancellationToken parameters must come last by @panosru in #772" should be listed as a Breaking Change.

IMO: The previous method with CancellationToken as 2nd param could have been marked with an obsolete tag and allowed to build.
@jbogard
Copy link
Owner

jbogard commented Oct 20, 2022

Many people do warnings as errors so it would have the same effect. Best to rip the bandage off.

@jbogard jbogard closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbogard @jeparrish