CA1068: CancellationToken parameters must come last #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been modified to follow the CA1068 rule, which indicates that the CancellationToken parameter must come last, while in some of MediatR methods the rule was followed, in many others it wasn't.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1068
The tests are also modified accordingly:
HandleandPublishnow taking thenextas a second param and thecancelationTokenas the last param.Although this pull request isn't backwards compatible, the modification isn't hard to implement, all it needs is to switch places between
nextandcancelationTokenarguments.