Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Auto Registration of Generic Handlers Feature #1060

Conversation

zachpainter77
Copy link
Contributor

@zachpainter77 zachpainter77 commented Aug 4, 2024

This PR completely removes the Auto-Registration of open Generic Request Handlers.

@jbogard I have made this pr so that you can decide what you want to do. Either remove the feature completely or make it Opt-In until we can implement a better resolution strategy.

If this PR is accepted and merged then I will maintain this feature as an extension method in a separate nuget package.

@zachpainter77 zachpainter77 changed the title Remove auto registration generic handlers Remove Auto Registration of Generic Handlers Feature Aug 4, 2024
Copy link

github-actions bot commented Sep 2, 2024

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 2, 2024
@jbogard jbogard removed the Stale label Sep 3, 2024
@jbogard
Copy link
Owner

jbogard commented Sep 3, 2024

I think what I'll do here is keep the tests because they represent the features I'd like to support, but remove the implementation. That it should be able to handle the use cases without any additional configuration. Is it possible to modify the PR to do that?

@jbogard
Copy link
Owner

jbogard commented Sep 3, 2024

And yes the build will fail but that's OK

@zachpainter77
Copy link
Contributor Author

zachpainter77 commented Sep 4, 2024 via email

@zachpainter77
Copy link
Contributor Author

@jbogard with the completion of pr #1057 do you think it's best to reject this pr and create a new one to remove the functionality but keep the failing tests to allow for development to tackle this in the way you were wanting to?

I feel like it would be easier to just pull in changes from the opt in pr and work from there.

@jbogard
Copy link
Owner

jbogard commented Sep 9, 2024

Yeah I think you're right there.

@zachpainter77
Copy link
Contributor Author

Closing this PR and creating a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants