MediatR.Examples.Windsor fix bug created by me before #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandruchirita4192
commented
May 20, 2022
•
alexandruchirita4192
commented
- Better checking of baseRequestType and checking assumptions with Debug.Assert instead of writing assumptions as comments
- Handling both request exception actions (that log the exception) and request exception handlers (that log the handler) in Program.cs in the correct order; extracted some methods in Program.cs and tried to give them meaningful names (sadly some methods could have better names though)
- Removed writing exception types in exception handlers after better understanding and wrote comments instead to understand what should actually write these exception names (LogExceptionAction from examples is actually writing exception names); sorry for this bug created by myself
- Added a small check in Runner.cs to ensure the method is not throwing an exception in case this method is called with less lines in messages list (split by end of lines)
…g.Assert instead of writing them as comments
- Fixed ExceptionHandlers.cs and ExceptionHandlersOverrides.cs comments to explain why something is needed and in which order - Fixed Runner.cs comments to explain what is actually writing the expected message - Fixed Program.cs for Castle Windsor example to handle both IRequestExceptionAction<,> and IRequestExceptionHandler<,,> by exctracting some methods and handling them both (there are more changes in Program.cs only because of extracting methods)
jbogard
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.