Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual request type in new 'Send' method #844

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

remcoros
Copy link
Contributor

@remcoros remcoros commented Feb 15, 2023

See this old issue for background: #124

var requests = new IRequest[] { new Req1(), new Req2(), new Req3() };
foreach (var req in requests)
{
  await _mediator.Send(req);
}

It will try to resolve handlers of type "IRequest" instead of using the concrete type of the given request.

sorry I didn't catch that yesterday 😞 let me know if I should add a test

@remcoros remcoros changed the title Use actual request type Use actual request type in new 'Send' method Feb 15, 2023
@jbogard
Copy link
Owner

jbogard commented Feb 15, 2023

Can you add a test for this? So I don't break it again.

@jbogard jbogard merged commit 59c9727 into jbogard:master Feb 15, 2023
@jbogard
Copy link
Owner

jbogard commented Feb 15, 2023

I'll wait a bit to see if there are any other bugs before making a release for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants