AddOpenBehavior(type) now supports stream behaviors without duplicate registrations #860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
MediatRServiceConfiguration.AddOpenBehavior(type)
assumed that the type parameter implementedIPipelineBehavior<,>
. It now supportsIStreamPipelineBehavior<,>
and throws anInvalidOperationException
the type parameter is not actually an open behavior. Added multiple tests.TryAddTransientExact
was replaced by the built-inIServiceCollection.TryAddEnumerable
that does the exact same thing, i.e. skip a registration if there's already a service descriptor that exactly match the service type AND implementation type. Modified an existing test to prove that everything behaves as before.MediatRServiceConfiguration.BehaviorsToRegister
consumption now useTryAddEnumerable
too. Covered by the modified test from the previous point.Apply the 11.x to 12.x migration guide in test classes: several test open behaviors were not using the right generic constraint, which is now
TRequest : notnull
.