Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Structure #188

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Update Project Structure #188

merged 1 commit into from
Aug 18, 2022

Conversation

jborean93
Copy link
Owner

Updates the project structure to use a PEP 517 pyproject.toml definition
and migrates the code outside of the project root into the src folder
layout. This aligns the project with most of my other project layouts
and utilises newer standards that avoid setuptool specific
configurations going forward.

Other changes include auto formatting the files with black and isort to
ensure a consistent Python code style and vscode configuration files to
have this done automatically.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #188 (a0bbf0c) into master (ba90646) will increase coverage by 0.00%.
The diff coverage is 99.74%.

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          23       24    +1     
  Lines        5063     5069    +6     
=======================================
+ Hits         5017     5023    +6     
  Misses         46       46           
Flag Coverage Δ
macOS 68.25% <65.95%> (+0.03%) ⬆️
py3.10 99.07% <99.66%> (+<0.01%) ⬆️
py3.6 ?
py3.7 99.07% <99.66%> (+<0.01%) ⬆️
py3.8 99.07% <99.66%> (+<0.01%) ⬆️
py3.9 99.09% <99.74%> (+<0.01%) ⬆️
ubuntu 96.77% <98.13%> (+<0.01%) ⬆️
windows 99.01% <99.57%> (+<0.01%) ⬆️
x64 99.09% <99.74%> (+<0.01%) ⬆️
x86 99.01% <99.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbprotocol/__init__.py 100.00% <ø> (ø)
src/smbprotocol/tree.py 96.68% <96.00%> (ø)
src/smbprotocol/session.py 95.18% <96.42%> (ø)
src/smbclient/__init__.py 100.00% <100.00%> (ø)
src/smbclient/_io.py 99.02% <100.00%> (ø)
src/smbclient/_os.py 98.48% <100.00%> (ø)
src/smbclient/_pool.py 95.89% <100.00%> (ø)
src/smbclient/path.py 90.69% <100.00%> (ø)
src/smbclient/shutil.py 95.19% <100.00%> (ø)
src/smbprotocol/_text.py 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Updates the project structure to use a PEP 517 pyproject.toml definition
and migrates the code outside of the project root into the src folder
layout. This aligns the project with most of my other project layouts
and utilises newer standards that avoid setuptool specific
configurations going forward.

Other changes include auto formatting the files with black and isort to
ensure a consistent Python code style and vscode configuration files to
have this done automatically.
@jborean93 jborean93 merged commit 73d0d00 into master Aug 18, 2022
@jborean93 jborean93 deleted the isort-black branch August 18, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant