Python3 style updates #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't run black/isort on |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 24 24
Lines 5082 5082
=======================================
Hits 5035 5035
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jborean93
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given "Python 3.7+" is listed as requirement, there are a few things that could be updated.
Also cleanup a previous "black" run that removed linebreaks between string literals but didn't merge them.
Regarding the
super(...)cleanup: there was one non-trivial use in_SMBErrorRegistry.__call__which I replaced withtype.__call__. Perhaps this method should start withif cls != SMBResponseException: return super().__call__(header)anyway - or ensure the status code of a passed header matches thecls._STATUS_CODEfor subclasses (or even forbid passing a header to subclasses).(The git history looks a little bit like you squash PRs to merge them? I'd appreciate it if you don't do that with mine - I split my changes into commits on purpose, and I'm happy to rebase/edit them :) )