Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for remote to local operations in shutil.py::copytree #226

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

brno32
Copy link
Contributor

@brno32 brno32 commented Jun 26, 2023

Step 1 to address #221

Splitting this into two PRs.

I had trouble getting the tests to work locally (even the unit tests that don't need an actual samba share to talk to), but tested manually. I am expecting the test I added to pass in CI

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #226 (66f5609) into master (8008656) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   99.07%   99.09%   +0.01%     
==========================================
  Files          24       24              
  Lines        5082     5083       +1     
==========================================
+ Hits         5035     5037       +2     
+ Misses         47       46       -1     
Flag Coverage Δ
99.09% <100.00%> (+0.01%) ⬆️
py3.10 99.05% <100.00%> (+0.01%) ⬆️
py3.11 99.05% <100.00%> (+0.09%) ⬆️
py3.7 99.05% <100.00%> (+0.01%) ⬆️
py3.8 99.05% <100.00%> (+0.01%) ⬆️
py3.9 99.09% <100.00%> (+0.10%) ⬆️
x64 99.09% <100.00%> (+0.01%) ⬆️
x86 99.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/shutil.py 95.71% <100.00%> (+0.52%) ⬆️

... and 5 files with indirect coverage changes

@brno32 brno32 force-pushed the copytree-remote-to-local branch from b33abc7 to afcf6fe Compare June 26, 2023 09:14
@brno32 brno32 force-pushed the copytree-remote-to-local branch from afcf6fe to 66f5609 Compare June 26, 2023 09:31
@jborean93 jborean93 merged commit 285ad28 into jborean93:master Jun 27, 2023
@jborean93
Copy link
Owner

Thanks for working on this.

@brno32 brno32 deleted the copytree-remote-to-local branch June 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants