adding support for local to remote operations in shutil.py::copytree #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 99.09% 99.07% -0.02%
==========================================
Files 24 24
Lines 5081 5085 +4
==========================================
+ Hits 5035 5038 +3
- Misses 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
brno32
force-pushed
the
copytree-local-to-remote
branch
from
d20b026 to
a4e3e9b
Compare
brno32
force-pushed
the
copytree-local-to-remote
branch
from
a4e3e9b to
337cc04
Compare
|
@jborean93 are you okay with this kind of approach? |
|
Hey sorry I haven't had a chance to look at this yet, I've got a few things on my plate right now. |
jborean93
reviewed
Jul 18, 2023
|
Good suggestions! I can work on tackling symlinks next if this looks like a good starting point |
jborean93
approved these changes
Jul 19, 2023
|
Sorry it took so long to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pt. 2 of addressing #221
Tackling symlinks looks a little daunting, so I'd like to circle back after making sure my current approach is aligned with the project.
It crossed my mind to have both
LocalDirEntryandSMBDirEntryinherit from the same abstract class, but I've opted to keep it simple