Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutil.copyfile will open source with read share #265

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

jborean93
Copy link
Owner

Opens the source file used in shutil.copyfile with share_access="r" to ensure that it can be copied even if something else already has it opened with read access and grants further opens.

Fixes: #258

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e69397) 99.06% compared to head (2069a12) 98.98%.
Report is 1 commits behind head on master.

❗ Current head 2069a12 differs from pull request most recent head 6dc5e36. Consider uploading reports for the commit 6dc5e36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   99.06%   98.98%   -0.08%     
==========================================
  Files          24       24              
  Lines        5115     5116       +1     
==========================================
- Hits         5067     5064       -3     
- Misses         48       52       +4     
Flag Coverage Δ
98.98% <100.00%> (-0.08%) ⬇️
py3.10 98.94% <100.00%> (-0.08%) ⬇️
py3.11 98.94% <100.00%> (-0.08%) ⬇️
py3.12 98.94% <100.00%> (-0.08%) ⬇️
py3.7 98.93% <100.00%> (-0.08%) ⬇️
py3.8 98.94% <100.00%> (-0.08%) ⬇️
py3.9 98.98% <100.00%> (-0.08%) ⬇️
x64 98.98% <100.00%> (-0.08%) ⬇️
x86 98.90% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Opens the source file used in shutil.copyfile with share_access="r" to
ensure that it can be copied even if something else already has it
opened with read access and grants further opens.
@jborean93 jborean93 merged commit ba9e9bc into master Jan 29, 2024
27 checks passed
@jborean93 jborean93 deleted the copyfile-tests branch January 29, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use share_access="r" with smbclient.shutil.copytree()
1 participant