Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up compound request session and tree ids #266

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix up compound request session and tree ids #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Stop using `datetime.datetime.utcfromtimestamp()` as it has been deprecated
* Added default timeout for disconnect operations for 60 seconds to ensure the process doesn't hang forever when closing a broken connection
* `smbprotocol.connection.Connection.disconnect()` now waits (with a timeout) for the message processing threads to be stopped before returning.
* Do not set the SMB SessionId and TreeId in the headers to `0xFFFFFFFF` for related compound requests

## 1.12.0 - 2023-11-09

Expand Down
2 changes: 0 additions & 2 deletions src/smbprotocol/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,8 +1256,6 @@ def _send(
header["flags"].set_flag(Smb2Flags.SMB2_FLAGS_DFS_OPERATIONS)

if i != 0 and related:
header["session_id"] = b"\xff" * 8
header["tree_id"] = b"\xff" * 4
header["flags"].set_flag(Smb2Flags.SMB2_FLAGS_RELATED_OPERATIONS)

if force_signature or (session and session.signing_required and session.signing_key):
Expand Down
Loading