Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some type annotations, most notably to smbclient.open_file #295

Merged
merged 1 commit into from
Oct 18, 2024

Add some type annotations, most notably to `smbclient.open_file`

68e761f
Select commit
Loading
Failed to load commit list.
Merged

Add some type annotations, most notably to smbclient.open_file #295

Add some type annotations, most notably to `smbclient.open_file`
68e761f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 17, 2024 in 0s

99.06% (+0.00%) compared to 42804ca

View this Pull Request on Codecov

99.06% (+0.00%) compared to 42804ca

Details

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.06%. Comparing base (42804ca) to head (68e761f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/smbclient/_os.py 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          24       24           
  Lines        5117     5146   +29     
=======================================
+ Hits         5069     5098   +29     
  Misses         48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov