Pmd 7 pmd7 merge master #489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) from 1.6 to 3.0.1. - [Release notes](https://github.com/apache/maven-gpg-plugin/releases) - [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-1.6...maven-gpg-plugin-3.0.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-gpg-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0-M1 to 3.1.0. - [Release notes](https://github.com/apache/maven-enforcer/releases) - [Commits](apache/maven-enforcer@enforcer-3.0.0-M1...enforcer-3.1.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-enforcer-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
available again from Sonar marketplace
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.2.0 to 3.4.1. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.2.0...maven-javadoc-plugin-3.4.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
attribute name should use rule.ruleKey().rule()
Bumps [sonar-orchestrator](https://github.com/SonarSource/orchestrator) from 3.37.0.87 to 3.40.0.183. - [Release notes](https://github.com/SonarSource/orchestrator/releases) - [Commits](SonarSource/orchestrator@3.37.0.87...3.40.0.183) --- updated-dependencies: - dependency-name: org.sonarsource.orchestrator:sonar-orchestrator dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.8.2 to 5.9.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.8.2...r5.9.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [java-frontend](https://github.com/SonarSource/sonar-java) from 7.12.0.29739 to 7.16.0.30901. - [Release notes](https://github.com/SonarSource/sonar-java/releases) - [Commits](SonarSource/sonar-java@7.12.0.29739...7.16.0.30901) --- updated-dependencies: - dependency-name: org.sonarsource.java:java-frontend dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps assertj-core from 3.22.0 to 3.24.2. --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bump maven-gpg-plugin from 1.6 to 3.0.1
Bump maven-enforcer-plugin from 3.0.0-M1 to 3.1.0
Bump maven-javadoc-plugin from 3.2.0 to 3.4.1
Bump sonar-orchestrator from 3.37.0.87 to 3.40.0.183
Bump junit-jupiter from 5.8.2 to 5.9.2
Bump java-frontend from 7.12.0.29739 to 7.16.0.30901
Bump assertj-core from 3.22.0 to 3.24.2
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 5.0.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.5.1...v5.0.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bump mockito-core from 4.5.1 to 5.0.0
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.4.1 to 3.5.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.4.1...maven-javadoc-plugin-3.5.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 2.22.2 to 3.0.0. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-2.22.2...surefire-3.0.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [maven-release-plugin](https://github.com/apache/maven-release) from 2.5.3 to 3.0.0. - [Release notes](https://github.com/apache/maven-release/releases) - [Commits](apache/maven-release@maven-release-2.5.3...maven-release-3.0.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-release-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sonar-orchestrator](https://github.com/SonarSource/orchestrator) from 3.40.0.183 to 3.42.0.312. - [Release notes](https://github.com/SonarSource/orchestrator/releases) - [Commits](SonarSource/orchestrator@3.40.0.183...3.42.0.312) --- updated-dependencies: - dependency-name: org.sonarsource.orchestrator:sonar-orchestrator dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.8 to 0.8.9. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](jacoco/jacoco@v0.8.8...v0.8.9) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mockito-core](https://github.com/mockito/mockito) from 5.0.0 to 5.3.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.0.0...v5.3.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…en.plugins-maven-javadoc-plugin-3.5.0 Bump maven-javadoc-plugin from 3.4.1 to 3.5.0
…en.plugins-maven-surefire-plugin-3.0.0 Bump maven-surefire-plugin from 2.22.2 to 3.0.0
Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/apache/maven-enforcer/releases) - [Commits](apache/maven-enforcer@enforcer-3.1.0...enforcer-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-enforcer-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…en.plugins-maven-gpg-plugin-3.2.4 Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.4
…en.plugins-maven-failsafe-plugin-3.2.5 Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.1.2 to 3.2.5
…en.plugins-maven-enforcer-plugin-3.4.1 Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.3.0 to 3.4.1
…e.java-java-frontend-7.34.0.35958 Bump org.sonarsource.java:java-frontend from 7.30.0.34429 to 7.34.0.35958
…ator.version-4.9.0.1920 Bump sonar-orchestrator.version from 4.7.1.1872 to 4.9.0.1920
version.sonar-packaging.plugin to 1.23.0.740 sonarQubeMinVersion 9.8 to pluginApiMinVersion 9.9
Update sonar-plugin-api-impl.version > 9.9.4.87374 sonar-plugin-api.version > 9.14.0.375
…t java 11 version
Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.1.0-jre to 33.2.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…va-guava-33.2.0-jre build(deps): bump com.google.guava:guava from 33.1.0-jre to 33.2.0-jre
… maven central for test
…to deploy SNAPSHOT to maven central
…ade sonar.maven.plugin, init PmdTestOrchestrator for each PmdIT test run
|
jborgers
approved these changes
Dec 9, 2024
| } | ||
|
|
||
| private static String determineSonarqubeVersion() { | ||
| return System.getProperty(SONAR_VERSION_KEY, "LATEST_RELEASE[9.4]"); | ||
| return System.getProperty(SONAR_VERSION_KEY, "LATEST_RELEASE[9.8]"); |
There was a problem hiding this comment.
Moet dit niet 10.x zijn inmiddels?
| @@ -298,12 +298,6 @@ | |||
| <repositoryKey>pmd7</repositoryKey> | |||
There was a problem hiding this comment.
ik denk dat deze key gaat zorgen voor een gehele rule definitie re-fresh! Want Kotlin regels konden zo naast java regels bestaan.
There was a problem hiding this comment.
should we use a separate key for kotlin? e.g. pmd-kotlin? To avoid same rule name clashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review the merge of master into pmd-7-pmd7 branch.
This includes updating dependencies, except those that would update the sonar qube version to run against.
This merge moves away from PMD 7.0.0-SNAPSHOT to PMD 7.8.0. There are quite some changes in API and removed rules.
We need to pay attention to the set of rules that is still present: can we remove more (deprecated) references?
And the other way around: are there new rules that should be included? (we may do this is a later update?)
There seems to be an issue with renamed rules, currently some rules are commented out to cope with that. Search for
PMD7-MIGRATIONcomments.