Replace StringBuffer with StringBuilder, other minor String optimizations #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
commented
Jul 16, 2021
| @@ -218,7 +218,7 @@ private String getMethodName(int opcode) { | |||
| break; | |||
| } | |||
|
|
|||
| if (methodName.equals("")) | |||
| if ("".equals(methodName)) | |||
There was a problem hiding this comment.
This version is safe even if 'methodName' is null.
tim-hoffman
commented
Jul 16, 2021
| @@ -473,7 +473,7 @@ private void atWhileStmnt(Stmnt st, boolean notDo) throws CompileError { | |||
| boolean alwaysBranch = compileBooleanExpr(true, expr); | |||
| if (alwaysBranch) { | |||
| bytecode.addOpcode(Opcode.GOTO); | |||
| alwaysBranch = breakList.size() == 0; | |||
| alwaysBranch = breakList.isEmpty(); | |||
There was a problem hiding this comment.
Using isEmpty() should perform better compared to computing the entire size().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace most uses of StringBuffer with StringBuilder to avoid the unnecessary synchronization from StringBuffer.
Replaced string concatenation within an append with multiple appends.
Remove unnecessary toString() calls on String instances.
Change length 1 string arguments of StringBuilder#append to character append (should have slightly better performance).