Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in no-standard [new] instruction replace #448

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

catsalty
Copy link
Contributor

A standard new construct bytecode will generate like:

new okhttp3/OkHttpClient
dup
invokespecial okhttp3/OkHttpClient <init> ()V
astore 1

but a few part of compiler will generate no-standard bytecode like:

new okhttp3/OkHttpClient
dup
astore 1
invokespecial okhttp3/OkHttpClient <init> ()V

which will cause javassist build stack error.

This commit will fix it

A standard *new* construct bytecode will generate like:

```
new okhttp3/OkHttpClient
dup
invokespecial okhttp3/OkHttpClient <init> ()V
astore 1
```

but a few part of compiler will generate no-standard bytecode like:

```
new okhttp3/OkHttpClient
dup
astore 1
invokespecial okhttp3/OkHttpClient <init> ()V
```
which will cause javassist build stack error.

This commit will fix it
@catsalty
Copy link
Contributor Author

relate issue:
#322

@chibash chibash merged commit cbb59bd into jboss-javassist:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants