-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bytecode compatible back to 52(JDK8) #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.idea/compiler.xml
This file should not be checked in, it is in .gitignore
IDEA need it. I can't find another way to make IDEA auto import work. In addition, being in |
This is just a configuration file for a personal local development tool that is independent of the source code and build,It's generally recommended not to include IDE-specific configuration files in the repository, as they are specific to each developer's local environment. |
|
@shifujun How about you bridge the divide here. No one wants to see anything .idea checked in. So why not add to the README for IDEA users they need to do that and put the same in change log once release is tagged and updated? That seems like a compromise that will fix this back for now. For reference, I'm over at https://github.com/mybatis/ and we shade this and cannot upgrade to this version without raising to java 11. We are still discussing where we want to raise but this report https://newrelic.com/resources/report/2023-state-of-the-java-ecosystem shows there is still a lot of life left with java 8. So I think don't press people to have idea configuration files on a repo. That isn't helpful, but if you need them to know how, document it instead. |
This project need JDK 11 to compile, but target to JDK 8. IDEA need uncheck "use --release" in Preferences | Build, Execution, Deployment | Compiler | Java Compiler , to build success. fix jboss-javassist#470
d7912e0
to
dc5aefe
Compare
@wuwen5 - We need to get this fix to get some of our applications working again. Any chance this can be merged and released ASAP? |
I'll release this by this weekend. Is this too late? |
@chibash - I appreciate the quick response on the merge! Thank you! At least for me, the sooner the better, but I totally understand if you need to wait a few days. -Thanks! |
This project need JDK 11 to compile, but target to JDK 8.
IDEA need uncheck "use --release" in Preferences |
Build, Execution, Deployment | Compiler | Java Compiler
, to build success.
fix #470