[LOGMGR-155] Added XML and JSON formatters. Also some general framewo… #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
commented
Jun 13, 2017
| return writer.toString(); | ||
| } catch (Exception e) { | ||
| // Wrap and rethrow | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
This needs to be removed.
pom.xml
Outdated
| <artifactId>javax.json</artifactId> | ||
| <version>${version.org.glassfish.javax.json}</version> | ||
| <!-- Marked as provided as any valid JSON implementation can be used if the JsonFormatter is desired --> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Should this just marked as <scope>test</scope> or possibly even <scope>compile</scope> since the JsonFormatter wouldn't work with some kind of implementation.
There was a problem hiding this comment.
I think the right choice is probably to use "compile" scope but make it optional.
…rk for a StructuredFormatter to allow for oher types of structured data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rk for a StructuredFormatter to allow for oher types of structured data.
https://issues.jboss.org/browse/LOGMGR-155