[LOGMGR-133] Java 9 integration #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
Something we may need to consider, could be an easy change, but the source JAR may not contain all the correct source. It likely only contains the JDK 8 source. Other than that I think this approach makes sense.
The JDKSpecific should probably override the findCallingClasses() too. We can handle that in a follow up though.
To test on both Java 8 and Java 9, use this command: mvn clean install -Djava8.home=/path/to/jdk/8
jamezp
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test on both Java 8 and Java 9, use this command:
mvn clean install -Djava8.home=/path/to/jdk/8