Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbeap 14320 #180

Merged
merged 1 commit into from
May 10, 2018
Merged

Jbeap 14320 #180

merged 1 commit into from
May 10, 2018

Conversation

adamecp
Copy link
Contributor

@adamecp adamecp commented Apr 6, 2018

JIRA task [https://issues.jboss.org/browse/JBEAP-14320](https://issues.jboss.org/browse/JBEAP-14320 - Amend NullPointerException in RegexFilter.isLoggable())

Description: When log message is null, RegexFilter.isLoggable() throws NullPointerException.

https://github.com/jboss-logging/jboss-logmanager/blob/master/src/main/java/org/jboss/logmanager/filters/RegexFilter.java#L63
It often results in unexpected outcomes. For example, assuming you have a filter-spec with "not(match(xxx))" to suppress some messages in your logger configuration...

@adamecp adamecp changed the base branch from master to 2.0 April 6, 2018 07:43
@gaol
Copy link

gaol commented Apr 11, 2018

The PR to the master branch is: #181
The original PR to fix https://issues.jboss.org/browse/JBEAP-14320 is: #175

@jamezp could you please check this? Thank you. :)

@jamezp
Copy link
Member

jamezp commented May 8, 2018

Only closing to test a CI build trigger.

@jamezp jamezp closed this May 8, 2018
@jamezp jamezp reopened this May 8, 2018
@jamezp jamezp closed this May 8, 2018
@jamezp jamezp reopened this May 8, 2018
@jamezp
Copy link
Member

jamezp commented May 8, 2018

Sorry for the noise, just doing one more test.

@jamezp jamezp closed this May 8, 2018
@jamezp jamezp reopened this May 8, 2018
@jamezp jamezp closed this May 8, 2018
@jamezp jamezp reopened this May 8, 2018
@jamezp jamezp force-pushed the JBEAP-14320 branch 2 times, most recently from a59365d to 95d86dd Compare May 10, 2018 02:12
@jamezp jamezp closed this May 10, 2018
@jamezp jamezp reopened this May 10, 2018
@jamezp jamezp closed this May 10, 2018
@jamezp jamezp reopened this May 10, 2018
@jamezp jamezp merged commit 212e0ca into jboss-logging:2.0 May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants