Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGMGR-280] SocketHandlerTests hangs on some JDKs #318

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

marekkopecky
Copy link
Contributor

@marekkopecky marekkopecky commented Oct 12, 2020

See the details (CI runs included) on comments on upstream jira: https://issues.redhat.com/browse/LOGMGR-280

Main JDK jira: https://bugs.openjdk.java.net/browse/JDK-8219991

Issue won't be fixed in JDK8 (see https://bugs.openjdk.java.net/browse/JDK-8253471 ), so I ignore affected test methods for all JDK8

Issue is fixed in OpenJDK 11.0.8 ( https://bugs.openjdk.java.net/browse/JDK-8241217 ). Issue will be fixed in OracleJDK 11.0.9 ( https://bugs.openjdk.java.net/browse/JDK-8247345 )

2.1 PR (this one): #318
2.2 PR: #321
2.3 PR: #319
master PR: #320

@marekkopecky
Copy link
Contributor Author

@jamezp Can you please check and possibly merge this PR?

@jamezp
Copy link
Member

jamezp commented Nov 11, 2020

FYI I'm ignoring this PR I'm just trying to decide if we want to do this since it's a test issue only.

@marekkopecky
Copy link
Contributor Author

marekkopecky commented Nov 12, 2020

decide if we want to do this since it's a test issue only.

@jamezp In my PoV we want to have this TS passing. What is your objections here?

@jamezp
Copy link
Member

jamezp commented Nov 12, 2020

@marekkopecky My only objection is it's a bug in the JDK itself and should be fixed in the future. So the solution is using an updated JDK.

It also passes for me on;

openjdk version "11.0.8" 2020-07-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+10, mixed mode)

@jamezp
Copy link
Member

jamezp commented Nov 12, 2020

Well now that I found https://issues.redhat.com/browse/LOGMGR-281 I'm guessing we are going to need to do something here.

@jamezp jamezp merged commit 46c9133 into jboss-logging:2.1 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants