Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long thread IDs #444

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add support for long thread IDs #444

merged 1 commit into from
Nov 13, 2023

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Nov 10, 2023

An idea for supporting long thread IDs before we have a requirement for Java 17. Avoids MR-JAR complexities by instead relying on MethodHandle complexities.

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@dmlloyd dmlloyd marked this pull request as ready for review November 13, 2023 19:10
@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 13, 2023

Reviewing again, I guess I can't see any obvious problems, and the tests all seem to pass. I guess we can go with it, if you want.

@jamezp jamezp merged commit d2947a5 into jboss-logging:main Nov 13, 2023
3 checks passed
@dmlloyd dmlloyd deleted the lti branch November 13, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants