Cater to legacy handlers #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I did not do was extend the test to see if the formatter of the handler is a "legacy" formatter. I think I'll update this with that fix as well. (Edit: done) |
dmlloyd
force-pushed
the
legacy-handlers
branch
from
d34ac96 to
1acf707
Compare
dmlloyd
force-pushed
the
legacy-handlers
branch
from
1acf707 to
3d97fc4
Compare
jamezp
approved these changes
Nov 28, 2023
|
This makes sense to me. |
dmlloyd
added a commit
to dmlloyd/jboss-logmanager
that referenced
this pull request
Nov 29, 2023
Follow up on jboss-logging#449 to apply the same treatment to sub-handlers of a handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy handlers (more accurately, handlers with legacy formatters) do not know how to properly format
printf-style messages. When we publish such records, we should apply a simplified formatting so that things like Gradle which unconditionally capture JUL output using an old handler will produce some kind of reasonable output.Relates to quarkusio/quarkus#22844.