Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGMGR-347] Do not use deprecated SmallRye Common OS Process #464

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Apr 3, 2024

See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).

Also removes PID cache from the syslog handler.

@dmlloyd dmlloyd requested a review from jamezp as a code owner April 3, 2024 13:34
@dmlloyd dmlloyd changed the title Do not use deprecated SmallRye Common OS Process [LOGMGR-347] Do not use deprecated SmallRye Common OS Process Apr 3, 2024
See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).
@jamezp jamezp merged commit f32bb80 into jboss-logging:main Apr 3, 2024
3 checks passed
@jamezp
Copy link
Member

jamezp commented Apr 3, 2024

We're just picking away at smallrye-commons in here and I like it :) The less dependencies for a log manager the better IMO.

@dmlloyd dmlloyd deleted the pid branch April 3, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants