Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGMGR-141] Fix ending deletion length when truncating format parts. #98

Merged
merged 1 commit into from
Jun 28, 2016
Merged

[LOGMGR-141] Fix ending deletion length when truncating format parts. #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jboss/logmanager/formatters/Formatters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public void render(final StringBuilder builder, final ExtLogRecord record) {
final int overflow = writtenLen - maximumWidth;
if (overflow > 0) {
if (truncateBeginning) {
builder.delete(oldLen, overflow + 1);
builder.delete(oldLen, oldLen + overflow);
}
builder.setLength(newLen - overflow);
} else {
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/org/jboss/logmanager/formatters/PatternFormatterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ public void truncation() throws Exception {

formatter = new PatternFormatter("%-5.10m");
Assert.assertEquals("test ", formatter.format(record));

// Exact length truncation
final String msg = "test message";
formatter = new PatternFormatter("%c %-5.-7m");
Assert.assertEquals(CATEGORY + " message", formatter.format(createLogRecord(msg)));
}

@Test
Expand Down