Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMW-285 Adding JBoss Network API secrets to run Ansible demo successfully #134

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

RanabirChakraborty
Copy link
Contributor

@RanabirChakraborty RanabirChakraborty commented Jul 30, 2024

Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RanabirChakraborty Rather than adding this variable there, I think you should use directly the molecule_downstream.sh. Did you try that first?

@RanabirChakraborty
Copy link
Contributor Author

yes @rpelisse I have tried using it but it was not processing, and plus molecule.sh was already working fine so added the creds only.

@rpelisse
Copy link
Contributor

rpelisse commented Aug 2, 2024

Can you elaborate on what was failing with the downstream-molecule? Because, if we start moving "downstream logic" (and for sure API is downstream logic) into the upstream, it's going to be confusing...

@RanabirChakraborty
Copy link
Contributor Author

It'll require LAST_SUCCESS_FULL_BUILD_ID, PROJECT_UPSTREAM_NAME and also parent job details to run with molecule_downstream.sh. (details - ansible-eap-migration-demo/63)

@rpelisse
Copy link
Contributor

rpelisse commented Aug 2, 2024

Hum... 🤔

Yeah, in this case, we should modify the downstream-molecule.sh to skip those parts if not relevant, but that's too much work for now, so let's go for your option!

@rpelisse rpelisse merged commit d27c9ba into jboss-set:main Aug 2, 2024
1 check passed
@RanabirChakraborty RanabirChakraborty changed the title AMW-278 Adding JBoss Network API secrets to run Ansible demo successfully AMW-285 Adding JBoss Network API secrets to run Ansible demo successfully Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants