Attempt to solve a NPE, possibly due to concurrent usage of ManifestV…

…erifier
jboss-set · Nov 1, 2024 · fb9612c · fb9612c
1 parent 339d2c6
commit fb9612c
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/main/java/org/jboss/set/components/ManifestVerifier.java b/src/main/java/org/jboss/set/components/ManifestVerifier.java
@@ -13,7 +13,6 @@
 import java.net.URL;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -118,13 +117,11 @@ private static ArtifactCoordinate stream2Coord(Stream stream) {
     }
 
     static class BuildRecorder {
-        Map<PncComponent, Map<PncBuild.Id, Collection<ArtifactCoordinate>>> buildsByComponent = new HashMap<>();
+        Map<PncComponent, Map<PncBuild.Id, Collection<ArtifactCoordinate>>> buildsByComponent = new ConcurrentHashMap<>();
         void record(PncBuild.Id buildId, PncComponent component, ArtifactCoordinate artifactCoordinate) {
-            buildsByComponent.putIfAbsent(component, new ConcurrentHashMap<>());
-
-            buildsByComponent.get(component).putIfAbsent(buildId, new ConcurrentLinkedQueue<>());
-
-            buildsByComponent.get(component).get(buildId).add(artifactCoordinate);
+            Map<PncBuild.Id, Collection<ArtifactCoordinate>> buildToArtifacts = buildsByComponent.computeIfAbsent(component, k -> new ConcurrentHashMap<>());
+            Collection<ArtifactCoordinate> artifacts = buildToArtifacts.computeIfAbsent(buildId, k -> new ConcurrentLinkedQueue<>());
+            artifacts.add(artifactCoordinate);
         }
 
         Collection<PncComponent> recordedComponents() {