Skip to content

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Apr 2, 2024

Copy link
Contributor

@soul2zimate soul2zimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proposal and implementation.

LGTM in general, except some small suggestions apply to both new evaluators.


}

protected void processPresenceLabel(final Attribute<IssueData> issueKey, final Attribute<LabelData> labelsKey,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first three parameters seems unnecessary for this method, you can just use the actual value inside this method. The last parameter context also useless in this method.


@Override
public boolean support(ProcessorPhase processorPhase) {
if (processorPhase == ProcessorPhase.OPEN) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified to return processorPhase == ProcessorPhase.OPEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants