Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for a file to disable testing a specific Java level if the prop… #302

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Jun 6, 2024

…erty is defined rather than looking for a file to enable the profile.

The idea here is to enable the test profiles by default if the javaXX.home property is set unless a disable-test-javaXX file is defined. This allows testing with different Java versions by default instead of having to add files to each module of a multi-module project when you want to test a new Java version.

…erty is defined rather than looking for a file to enable the profile.

Signed-off-by: James R. Perkins <jperkins@redhat.com>
Signed-off-by: James R. Perkins <jperkins@redhat.com>
@dmlloyd
Copy link
Member

dmlloyd commented Aug 26, 2024

Seems OK in principle, once the bugs are worked out. I guess a lot of the test projects aren't testing on all available versions. Also you'd want to limit it so that you don't test on a version earlier than the minimum supported version (this is in a property IIRC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants