-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: javadoc plugin uses additionalOptions #51
Conversation
@ctomc can you cut the release with that fix? it breaks most of the @arquillian projects :( |
@bartoszmajsak Not anymore, I don't have push permissions anymore. |
I can try to release that if you grant me permission to this repo. |
pom.xml
Outdated
@@ -464,6 +464,7 @@ | |||
</manifestEntries> | |||
</archive> | |||
<additionalparam>${javadoc.additional.params}</additionalparam> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if additionalparam was replaced with additionalOptions the line should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stated the reason why I decided not to in the PR description:
I left
additionalparam
for backward compatibility in case someone uses old plugin by overwriting a version.
If you feel like it's not a reason good enough I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've missed that. May be it would be good to add the comment to the respective line why it is there (additionalparam line) and which versions of plugin it is meant for (both lines) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, added in b04d457
@psakar is there a chance to cut the release? |
@kabir this is up to you or somebody from EAP dev team |
Thanks @kabir, much appreciated! |
additionalparam
has be removed in favor ofadditionalOptions
- thus using-Xdoclint:none
with this parent pom is causing the build to fail regardless.I left
additionalparam
for backward compatibility in case someone uses old plugin by overwriting a version.