Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: javadoc plugin uses additionalOptions #51

Merged
merged 2 commits into from
Sep 6, 2018
Merged

fix: javadoc plugin uses additionalOptions #51

merged 2 commits into from
Sep 6, 2018

Conversation

bartoszmajsak
Copy link
Contributor

@bartoszmajsak bartoszmajsak commented Sep 5, 2018

additionalparam has be removed in favor of additionalOptions - thus using -Xdoclint:none with this parent pom is causing the build to fail regardless.

I left additionalparam for backward compatibility in case someone uses old plugin by overwriting a version.

@bartoszmajsak
Copy link
Contributor Author

bartoszmajsak commented Sep 5, 2018

@ctomc can you cut the release with that fix? it breaks most of the @arquillian projects :(

@ctomc
Copy link
Contributor

ctomc commented Sep 5, 2018

@bartoszmajsak Not anymore, I don't have push permissions anymore.
maybe someone else from EAP team can help.

@bartoszmajsak
Copy link
Contributor Author

I can try to release that if you grant me permission to this repo.

pom.xml Outdated
@@ -464,6 +464,7 @@
</manifestEntries>
</archive>
<additionalparam>${javadoc.additional.params}</additionalparam>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if additionalparam was replaced with additionalOptions the line should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stated the reason why I decided not to in the PR description:

I left additionalparam for backward compatibility in case someone uses old plugin by overwriting a version.

If you feel like it's not a reason good enough I can remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've missed that. May be it would be good to add the comment to the respective line why it is there (additionalparam line) and which versions of plugin it is meant for (both lines) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added in b04d457

@psakar psakar merged commit dab7eba into jboss:master Sep 6, 2018
@bartoszmajsak bartoszmajsak deleted the patch-1 branch September 6, 2018 20:54
@bartoszmajsak
Copy link
Contributor Author

@psakar is there a chance to cut the release?

@psakar
Copy link
Contributor

psakar commented Sep 7, 2018

@kabir this is up to you or somebody from EAP dev team

@kabir
Copy link
Contributor

kabir commented Sep 7, 2018

@psakar @bartoszmajsak released 29 https://github.com/jboss/jboss-parent-pom/commits/master

@bartoszmajsak
Copy link
Contributor Author

Thanks @kabir, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants