upgraded version.compiler.plugin #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kabir For OpenJDK 11 build compatibility, we need this PR merged and released. Would you mind taking a look? "Here are the recommended minimum versions for a few tools: |
|
This will now require a 3.8.0-jboss-1 tag for maven-compiler-plugin which has the additionalClassPathItems patch. |
|
The 3.8.0-jboss-1 tag is released to our Nexus instance. Now the PR just has to be updated; I'll go ahead and do that. |
dmlloyd
force-pushed
the
compiler.plugin
branch
from
d7b05ba
to
00fc808
Compare
dmlloyd
force-pushed
the
compiler.plugin
branch
from
00fc808
to
ce23dc7
Compare
|
All set! |
|
Any chance to contribute it back to the official maven compiler? |
|
@dmlloyd Thanks for picking this up David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
justification: see https://blog.codefx.org/java/java-11-migration-guide/
JDK11 build friendly