Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all repositories defined for the build are accessed over https. #63

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Apr 11, 2019

No description provided.

@psakar
Copy link
Contributor

psakar commented Apr 11, 2019

Can you please put it to separate profile activated by default ?
There are valid reasons to build with http repositories. See https://issues.jboss.org/browse/WFLY-11932 for further details

@darranl
Copy link
Contributor Author

darranl commented Apr 11, 2019

Sorry @psakar I should have added in the comment, I have also added support to specify -Denforcer.level=WARN to avoid the termination of the build after the enforcer plugin detects the use of http.

@darranl
Copy link
Contributor Author

darranl commented Apr 11, 2019

I have updated the system property so now -Dinsecure.repositories=WARN more accurately represents which aspect of the enforcer is affected by the property.

Copy link
Contributor

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is necessary to deal with the original issue, since local user settings can inadvertently bring in unsecured repositories.

@bstansberry bstansberry merged commit 9760148 into jboss:master Apr 26, 2019
msfm added a commit to msfm/maven-bash-completion that referenced this pull request Aug 17, 2019
Since jboss-parent pom version 35, it added http://* as
bannedRepositories to maven-enforcer-plugin setting by
the following commit/PR:

jboss/jboss-parent-pom@61e59fe8
jboss/jboss-parent-pom#63

You can specify -Dinsecure.repositories=WARN to avoid the termination
of the build after the enforcer plugin detects the use of http.
msfm added a commit to msfm/maven-bash-completion that referenced this pull request Dec 24, 2020
Since jboss-parent pom version 35, it added http://* as
bannedRepositories to maven-enforcer-plugin setting by
the following commit/PR:

jboss/jboss-parent-pom@61e59fe8
jboss/jboss-parent-pom#63

You can specify -Dinsecure.repositories=WARN to avoid the termination
of the build after the enforcer plugin detects the use of http.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants