[JBEAP-28618] Fix startup probe #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laDok8
reviewed
Nov 29, 2024
| initialDelaySeconds: 10 |
There was a problem hiding this comment.
while we're at it shouldn't we use WF values?
There was a problem hiding this comment.
I've aligned the values to have at most 2 minutes for the pod to start.
to point to /health/started Set `initialDelaySeconds` to 10 and failureThreshold to `11`. At most, the pod will wait 2 minutes (10 + 11 * 10 seconds) to be started. this fixes https://issues.redhat.com/browse/JBEAP-28618 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
JBEAP-28618_startup_probe
branch
from
6342a51 to
7ad93f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to point to /health/started
this fixes https://issues.redhat.com/browse/JBEAP-28618